ctapipe Daily Digest — Activity since 2025-05-12

» cta-observatory/ctapipe | cta-observatory/ctapipe

• cta-observatory/ctapipe repo issues [back to top]

  Nothing happening

• cta-observatory/ctapipe repo pull_requests [back to top]

  • Remove one level of indirection from DVR classes #2750 [maxnoe]

    • kosack: Looks good, just need to include the tel_id and selected_gain_channel in the tests and other...

    • Hckjs: One could separate the actual reduction algorithm in the __call__-function to its own function...

    • kosack

    • Hckjs

    • maxnoe: One could separate the actual reduction algorithm in the call-function to its own function and...

  • Use actual muon PDF for toy model ring #2751 [maxnoe]

    @burmist-git This implements the expected muon intensity distribution for the asymmetry of the toy model.

    • burmist-git: This does not include the muon inclination.

  • Muon fit improvement #2736 [burmist-git]

    The muon ring fitter needs to be improved. The existing toy tests for muons are overly simplified. Realistic...

    • mexanick: Thanks for this update. I have a few questions and suggestions inline. Besides, I noticed that...

      • mexanick: As we discussed offline, please add tests covering also LST geometry, and perhaps, nectarcam...

        • maxnoe: @burmist-git Has the comment here regarding test fragility been addressed?

        • burmist-git: @maxnoe yes and the origin of these fragility was simple we were very close to the boundary and...

    • mexanick: Suggested change max_var =...

      • burmist-git: I can repeat my answer again : Change raise Warning to warnings.warn in the last commit. During...

    • maxnoe: Looks mostly good, some remaining questions and style comments

      • maxnoe: I asked in another review if there would be a reason to switch off the error computation and...

        • maxnoe: How did you make this decision? How can performing unneeded computations "be ok for the...

        • burmist-git: @maxnoe .... Ok i putting back the nans.

      • maxnoe: The new uncertainties here are just ignored. They should also be tested.

        • maxnoe: I think it's reasonable to proceed with the merge request and include these new tests in a...

    • maxnoe: How can this happen?

      • burmist-git: only if var is nan and in case of inverse function method usage for more complex pdf...

      • maxnoe: in case of inverse function method usage for more complex pdf calculation. Where does this...

      • burmist-git: More complex pdf calculation happen in possible future :-) only. The toy model now is close to...

      • maxnoe: But why would you fit the toy model to real muon rings?

      • burmist-git: Actually the methods will do anything the toy will provide. we decided to test them with "real"...

      • burmist-git: And on more thing: the image intercity in current toy model is actually a function of its size,...

      • burmist-git: Or you asked me about the more complex pdf calculation - this may not happen. The whole story...

      • maxnoe: The pdf(NAN) = 0.0. I follow this logic only when I did the function implementation. I don't...

      • maxnoe: Which makes me think: shouldn't the linear PDF be defined in terms of center and radius (e.g....

      • burmist-git: The linear pdf is linear pdf you provide the shift and slope and its provide you the PDF minimum...

      • maxnoe: Yes, the slope is provided. However, the minimum and maximum values of the input variable still...

      • maxnoe: This could be fixed by replacing this linear distribution by something I asked in one of my...

      • maxnoe: More realistic would be using the actual PDF for muon rings, in terms of the impact parameter...

      • maxnoe: I opened #2751 targeting this PR with the last option

      • burmist-git: This about actual PDF for muon rings. @maxnoe This does not include the muon inclination w.r.t...

      • burmist-git: The first point : However, the minimum and maximum values of the input variable still...

      • maxnoe: This does not include the muon inclination w.r.t optical axis ... The intensity is not really a...

      • maxnoe: We have the full model in the intensity fitter, so I think there is no point in making the toy...

      • burmist-git: :-) still think it was doing the reasonable job the linear_pdf.

    • maxnoe

    • maxnoe: The test that fails in the CI passes locally for me, so it seems the comment regarding fragility...

    • burmist-git: @maxnoe can i see the logs ?

    • mexanick: @maxnoe @burmist-git this is the relevant portion of the log: FAILED...

    • burmist-git: @maxnoe probably the intensity have to be returned since new function (the muon pdf vs impact...

    • maxnoe: The phi_pdf does not integrate to 1. Looks like a factor 2π is missing: import astropy.units as...

    • burmist-git: Yes this ring can have problems :-).

    • burmist-git: So the intensity now is a strong function of rho. This has been changed and taken into account.

    • burmist-git: @maxnoe this effectively is the change of normalization. You probably got even more errors now....

    • maxnoe: The psi PDF should now be normalized correctly for all cases. I adjusted the image brightness...

created at 2025-05-13 06:33 by dinghy 1.4.1.