ctapipe Daily Digest — Activity since 2025-08-22

» cta-observatory/ctapipe | cta-observatory/ctapipe

• cta-observatory/ctapipe repo issues [back to top]

  • New method to reconstruct muon impact point #2815 [burmist-git] enhancement

    We need to implement a new method to reconstruct the impact point. With the current method, we achieve a 1.7 m...

    • maxnoe: How do you compute the true value? I don't think we have code for that in ctapipe, but it would...

    • burmist-git: Actually, with this configuration, the simulated true core X and true core Y are the correct...

    • burmist-git: @maxnoe The initial implementation appears satisfactory. the next step is to estimate the...

    • burmist-git: This is without camera shadowing

• cta-observatory/ctapipe repo pull_requests [back to top]

  • add impactpoint_intensity_fitter.py #2814 [burmist-git]

    An important error has been found and fixed (in the Chord calculation). It shows an improvement in the resolution...

  • add MonitoringSource #2802 [TjarkMiener] API change Breaking change hdf5 data format

    This PR prepares ctapipe to interface with camera calibration data products from calibpipe via a new MonitoringSource().

    • TjarkMiener

      • TjarkMiener: @TjarkMiener subarray here

      • TjarkMiener: Why we put the data level (top-level) here? Monitoring types should be decoupled from data levels.

        • maxnoe: Why? Monitoring information is related to data levels

      • TjarkMiener: I'm suggesting here: DRIVE_POSITIONS_GROUP = "/dl0/monitoring/telescope/pointing" And what is...

        • mexanick: I would leave it as is. In this group, you will have drive position, bending model corrections,...

        • mexanick: this is missed in all - perhaps causing the issue with the incomplete import during the doc build?

    • maxnoe: just curious... why does github syntax highlighting color FIXED_POINTING_GROUP differently? Any idea?

      • TjarkMiener: FIXED_POINTING_GROUP does not have an interger. Could this be?

      • TjarkMiener: Same for SIMULATION_*

    • maxnoe: I think it is fine to not expose these values at the ctapipe.io toplevel init. It's fine to have...

      • TjarkMiener: Just seeing it now! It should fix in the current version. Should be reverted?

      • maxnoe: I think this is very low-level info to be exposed at the top-level io module. So yes, I'd prefer...

      • TjarkMiener: Done

    • TjarkMiener: Should the DATA_MODEL_VERSION changed in the datawriter including the monitoring info?

    • maxnoe: mmh, something is going wrong with the coverage... Can you update with main?

    • maxnoe: docs build also fails with a circular import error: Extension error...

    • maxnoe: Use relative imports here, might fix the import error

      • maxnoe: if not, you can put the imports from ctapipe.io where needed, not at the top-level. I think the...

      • mexanick: no, this is properly circular import. PointingInterpolator is being used in io, but imports from...

      • maxnoe: I think it's ok in ctapipe.io.hdf5format, but either the import of the PointingInterpolator in...

      • mexanick: it is TableLoader that imports the PointingInterpolator, but that's not important. By...

      • maxnoe: HDF5EventSource also uses it: ctapipe/src/ctapipe/io/hdf5eventsource.py ...

      • mexanick: yes, I meant this particular issue was with TableLoader. I'm pretty sure there's more, and we...

      • maxnoe: Like I said, I think it makes semantical sense to keep the hdf5dataformat definitions in...

      • maxnoe: How can a data format be used beyond IO? I think it's rather a sign that the...

    • maxnoe: Since you have a close, you can call it here Suggested change ...

    • maxnoe: This looks mostly good to me, I'll make a detailed review pass next week. Since it's a pretty...

created at 2025-08-23 06:31 by dinghy 1.4.1.