ctapipe Bi-Weekly Digest — Activity since 2025-07-19

» cta-observatory/ctapipe | cta-observatory/ctapipe

• cta-observatory/ctapipe repo issues [back to top]

  • Support reading sim_telarray DST0 files #1777 [ParsonsRD] new functionality

    Hi all, The reading of the DST0 files (essentially dl1 data level) produced by Konrad's sim_telarray is currently...

  • Move data volume reduction from image to own submodule #1394 [maxnoe]

    This is it's own thing, it should either be it's own submodule or a part of calibration. I lean towards it being it...

  • remove support for calculating Hillas parameters in CameraFrame #2061 [kosack] refactoring

    see older issue: #1983 Now that everything works consistently in the TelescopeFrame for reconstruction, we should...

  • Make QualityQuery a TelescopeComponent and list of checks a TelescopeParameter #2158 [maxnoe] enhancement

    Please describe the use case that requires this feature. To support different cuts per telescope type. Describe the...

  • QualityQuery statistics are written to hdf5 file without the <kind> group #2177 [maxnoe] bug module:IO hdf5 data format

    Describe the bug ❯ h5dump -n gamma-diffuse_with_images_00.dl2.h5 | grep statistics dataset ...

  • Tool Documentation needs updates #2255 [kosack] documentation

    the tools page only lists a few of the existing tools and includes the old muon tool that no longer exists (may be...

  • Should we deprecate changed config options? #2521 [kosack]

    In #2520, I changed a bunch of config option names, which will break existing config files. Maybe before release...

  • Add tool to export astropy cache to specific location #2748 [maxnoe] enhancement

    Please describe the use case that requires this feature. For working offline and on clusters, we should have a tool...

  • ctapipe-quickstart prints many warnings #2794 [Tobychev] bug

    Describe the bug ctapipe-quickstart prints many warnings To Reproduce Run ctapipe-quickstart. Expected behavior That...

  • Warnings when calling get_bright_stars #2800 [moralejo] bug

    Warnings when calling ctapipe.utils.get_bright_stars Steps to reproduce the behavior: from ctapipe_io_lst.constants...

  • The chord calculation has a bug #2804 [burmist-git] bug

    Describe the bug The chord calculation has a bug. It does not account for non-physical solutions in the chord...

  • Enhancement of the muon analysis pipeline. #2760 [burmist-git] enhancement

    Please describe the use case that requires this feature. The muon analysis pipeline has recently been updated to...

    • burmist-git: LST mirror hole is...

    • burmist-git: Point 3) about the oversampling : The code to reproduce this error is...

    • burmist-git: The code to reproduce this error is...

    • burmist-git: The chord calculation has a bug. It does not account for non-physical solutions in the chord...

    • kosack: LST mirror hole is incorrect Those are default values, probably set many years ago from a very...

    • burmist-git: Those are default values, probably set many years ago from a very old simulation production, but...

    • burmist-git: Perhaps a better option would be to add this hole size to the OpticsDescription Definitely...

    • maxnoe: See #1252

    • burmist-git: @maxnoe So it wasn't resolved. I think I'll first add it to the YAML file and update the...

  • Change default values of `progress` bar option to `None` #2366 [maxnoe] enhancement good first issue

    Please describe the use case that requires this feature. tqdm can be smart with disable=None, in which case it will...

• cta-observatory/ctapipe repo pull_requests [back to top]

  • More ImPACT code cleanup #2705 [gschwefer]

    Hi everyone, I finally got around to clean up the ImPACT code a bit more. This PR has 3 major changes: The paths to...

    • ParsonsRD: Hi all, are there any actions that are needed to merge this PR? I think these commits are an...

  • New 3D shower model #1996 [StFroese] new functionality module:reco

    This is just a draft for now to review some ideas. This approach is based on this paper. The shower is basically a...

  • make qualityquery a telescopecomponent #2234 [nbiederbeck]

    Fixes #2158. This is currently ugly, as we now yield from a list with single value. This would need a change to...

  • Drop camera frame #2396 [StFroese] API change refactoring

    As you may remember, I already started this here #2141. A lot happened since the last time (i.e. moving the muon...

  • Fix warnings about missing meta in quickstart tool, fixes #2794 #2797 [maxnoe] no-changelog-needed

    • mexanick

  • Fix warnings raised by get_bright_stars #2801 [maxnoe]

    fixes #2800

    • moralejo

    • mexanick

  • Modify camera monitoring data format #2787 [TjarkMiener] data model change

    This PR implements the camera monitoring data format, which we will be proposing next week at the DPPS workshop....

    • kosack: Please update the docs under User Guide → Data Format to explain how these tables are stored.

    • kosack: Cnstruct → Construct

    • mexanick

    • maxnoe

    • mexanick: @kosack, @maxnoe I added the DL1/Monitoring section. It contains one placeholder (for actual...

    • kosack

    • maxnoe

  • Calibpipe interface #2802 [TjarkMiener]

    This PR prepares ctapipe to interface with camera calibration data products from calibpipe.

    • mexanick

      • mexanick: Please state some more details on the change, this is a breaking change. Also, this should be...

      • mexanick: I think this one and the above one can be merged in one (only the monitoring). Consider adding...

        • TjarkMiener: @mexanick Please see the latest commit 15387de how the containers being used e.g. in the...

      • mexanick: merge these conditions with application below, you check twice for None.

        • TjarkMiener: See e1d86a3

    • TjarkMiener: Coverage is low as expected because we do not have a monitoring file running in the CI and...

  • Set disable=None by default for progress bar in ctapipe tools #2444 [morcuended]

    Sets tqdm(..., disable=None) in process and merge ctapipe tools. By default the progress bar is displayed when...

  • Muon fit chord length fix #2803 [burmist-git]

    Modified the chord_length function to fix a bug. It now filters out non-physical solutions for chodr vs phi. Updated...

    • burmist-git: #2760 (comment)

    • mexanick

      • mexanick: Suggested change Filters out...

        • mexanick: @maxnoe any idea why this wasn't caught by the codespell pre-commit hook?

        • burmist-git: Done.

      • mexanick: according to sonar, these two lines are not covered by tests: if np.abs(phi) <...

        • burmist-git: These two lines are fully covered by this test. If you remove this check, the test will fail....

        • mexanick: your test verifies the part when condition np.abs(phi) < np.arcsin(1.0 / rho) is not met, but...

        • burmist-git: Okay, values where rho is greater than 1 and phi is 0 can be included

        • mexanick: You have four cases in the function: no chord, a muon outside of the circle, and two cases for...

        • burmist-git: Yes and now we have 4 tests : Two inside and two outside

      • mexanick: I think this function would benefit from better documentation. First of all, I find confusing...

        • burmist-git: The first point is addressed (discriminant_norm). However, I would refer to the second one as...

        • mexanick: I still find it confusing, as it is not a chord in the geometrical meaning. You can rename it to...

        • burmist-git: Ok lets call it : effective_chord_length

    • mexanick: Add a blank line between one-line summary and the body of the docstring. Add the paper to...

      • burmist-git: done

    • mexanick: I'm not sure why the sonar coverage is ill-computed... @kosack @maxnoe any idea? Could it be a...

    • burmist-git: This is a separate issue that was not addressed previously. The goal of this merge request is...

    • burmist-git: The docs are ok now ...

    • kosack

    • kosack: Looks good. Just did a quick test to see the effect, and I see no issues! Before fix, the left...

  • Generalise table preprocessing #2791 [Voutsi] module:irf

    Closes #2790 Refactoring the DL2 processing for producing IRFs. The motivation is to use the same code for more...

    • LukasBeiske: Why is the gh score included in the derived columns and not in the default table schema?

      • mexanick: It is used in make_derived_columns to attach the unit (dimensionless_unscaled), so it is not...

      • maxnoe: We do not attach units to things that don't have any, we use plain numpy arrays. What is the...

      • LukasBeiske: I remember this problem, although I'm not sure right now what caused it exactly. Besides that...

      • mexanick: the following conversion: self = Unit(dimensionless), other = Unit(dimensionless with a scale of...

      • kosack: Yes, please fix that elsewhere. As is, running this fails: proc =...

    • maxnoe

    • kosack

      • kosack: Confusing config parameter name: unclear what this would do from the name and the help text,...

        • Voutsi: Indeed the help was poorly written. What it does is actually this: Check whether the pointing is...

        • kosack: Ah, I understand now. This is used to disable the check on the pointing coordinate frame. I...

      • kosack: A comment I had in the original PR for this as well: this renaming is really just a stop-gap...

      • kosack: The only place where I could find this method being used is in a test fixture...

        • kosack: Ah, no I missed it's also used to make the "header" attribute (poorly named, see below) in...

      • kosack: not for this PR, but we should probably open an issue to change or add to the API of...

      • kosack: Does it need to be [header] if later you append header again? There must be a nicer way...

      • kosack: I think we should log a warning here, as this can effect results. "simulation distributions were...

      • kosack: Not a problem, just a comment, this is not just generalizing the simulation IRF pre-processing...

        • Voutsi: In principle in fact, what it looks like is that you really want to do cross-calibration on DL3...

      • kosack: I think this is a carry-over from the original code, but please rename some of these variables...

        • kosack: If this confusing code and the code in make_empty_table are just to get the column metadata...

    • mdebony: @Voutsi following Karl suggestion, I've taken a look at your PR. In the PR #2727 I've modified...

    • Voutsi: Hi @kosack , while I agree with your points, I believe that they are beyond the scope of this...

    • Voutsi: @Voutsi following Karl suggestion, I've taken a look at your PR. In the PR #2727 I've modified...

    • mdebony: Hi @mdebony , thanks for looking into it. I think our usecases are different. What we intent to...

    • Voutsi: Hi @mdebony , thanks for looking into it. I think our usecases are different. What we intent to...

    • mdebony: Do you see something that might be an obstacle for the production of DL3? My point remain, if...

    • kosack

created at 2025-08-02 06:34 by dinghy 1.4.1.