ctapipe Bi-Weekly Digest — Activity since 2025-01-20

• cta-observatory/ctapipe repo issues

  • numpy._core._exceptions._UFuncOutputCastingError in simteleventsource.py:974: in _generate_events #2683 [GernotMaier] bug

    Describe the bug This is the error message: ests/unit_tests/simtel/test_simulator_light_emission.py:316: _ _ _ _ _...

    • maxnoe: @GernotMaier yes, and already fixed here #2682 You can pin to numpy ~= 2.1.0 for now

  • Provenance config missing info for AstroQuantity values #2685 [kosack] bug

    Describe the bug The provenance log contains a config section with the results of tool.get_curent_config(). ...

    • maxnoe: The Provenance.as_json method defines a set_default method that returns None for unknown things,...

    • maxnoe: I opened a draft PR here #2688, raising an error for unknown objects in set_default. That's...

    • kosack: Just noticed also that the reference_metadata in the inputs section is also null. The...

    • maxnoe: The ReferenceMetadata object can convert to JSON, but might be looking at an older version It...

  • Store provenance in the actual output file #1610 [maxnoe] good first issue IO provenance

    I think we should not use an extra "provenance log file". If applicable (e.g. for all tools that produce a single...

    • kosack: I'd like to come back to this issue. After a discussion with @Tobychev, we now have a good use...

    • maxnoe: That avoids the var-length-string in table problem for pytables string attributes have a...

    • kosack: Ok, so needs some storage thought then... That just for attrs? Or if we create a string...

    • maxnoe: That's not really an issue, as you can store anything in the pickle, just add it t the...

    • kosack: Anyhow, this is not super-high priority, but since people will start soon to do some studies...

  • `SubarrayDescrption` missing telescopes in case of non-unique telescope description string #2672 [maxnoe] bug

    E.g. with the LSTs having different specs in Prod6: subarray.info() Subarray : LaPalma-prod6 Num Tels :...

• cta-observatory/ctapipe repo pull_requests

  • Add sphinx conf.py to RTD config #2681 [maxnoe] documentation maintenance no-changelog-needed documentation-only

    Seems to be required now

    • morcuended

    • maxnoe: I'll include the change here #2682

  • Add explicit cast necessary in numpy >=2.1 #2682 [maxnoe] maintenance

    • kosack

    • maxnoe: Sorry @kosack, needed to also include the change from #2681 to have green CI

    • kosack: Now I think you overwrote the numpy changes?

    • maxnoe: Rebase gone wrong, fixed thanks to git reflog

    • kosack

    • morcuended

  • Prepare 0.23.2 #2684 [maxnoe] no-changelog-needed documentation-only

    Prepare compatibility release for numpy 2.1 / 2.2

    • morcuended: It looks good. Just some minor language comments

      • morcuended: Suggested change A pull request...

      • morcuended: Suggested change #. conda packages...

    • kosack

    • Tobychev

    • morcuended

  • Fill `containers.SimulatedCameraContainer.true_image_sum` in HDF5eventsource #2680 [Hckjs] bug no-changelog-needed

    • maxnoe

    • kosack

    • maxnoe

    • kosack

  • Make sonar coverage badge link point to coverage #2686 [maxnoe] maintenance no-changelog-needed documentation-only

    Clicking on the badge would open the badge itself in a new tab.

    • Tobychev

    • morcuended

  • Muon parameters update #2670 [jstvdk] calibration

    I added new functionality to the muon analysis as described in the Issue #2665 , specifically new fields to the...

  • Perform changelog check only for pull requsts targeting main #2690 [maxnoe] maintenance no-changelog-needed

    • mexanick

    • kosack

  • Raise error to test what cannot be stored in json config #2688 [maxnoe]

    • maxnoe: With the changes made here, we are now down to the quantity, I can test if storing the string...

    • kosack: can test if storing the string works now. What is allowed if these are specified on the...

  • Add CI job testing on python 3.13 #2687 [maxnoe] maintenance no-changelog-needed

    Newest numba 0.61 is out and supports 3.13 According to the changelog, it also finally supports coverage reporting!

    • Tobychev: Why the change to a pinned version of ubuntu? Is that a restriction from numba?

      • maxnoe: To fix the warning: "WARNING: ubuntu-latest will soon be ubuntu-24.04". I think in general it's...

    • kosack

    • Tobychev

  • Hillas psi uncertainty ruo #2629 [ruoyushang]

    Adding estimation of image psi uncertainty and uncertainty of image cog along the rotated y-axis in hillas.py. Also...

    • ruoyushang: You can run it manually now to fix the past commits: git fetch pre-commit run --files $(git diff...

  • Add CI run running on oldest supported versions of core dependencies #2619 [maxnoe] no-changelog-needed

    • kosack

    • Tobychev

    • Tobychev: Is there really no other way than hardcoding the version numbers in the ci.yml config file?...

      • maxnoe: I didn't find an elegant solution to this. astropy for example also hard-codes their oldest...

    • Tobychev

  • Stats calc tool #2628 [TjarkMiener] calibration

    This PR adds a generic stats-calculation tool utilizing the PixelStatisticsCalculator. Related #2542

    • mexanick: @maxnoe @kosack @FrancaCassol The code is ready for review, please take a look.

    • kosack: should we merge, or do you want to wait for more reviews?

    • mexanick: I'd wait for @maxnoe review, then we can merge.

    • maxnoe: These are all configuration options. By hardcoding them here as kwargs, you prevent users from...

      • mexanick: @maxnoe fixed

    • mexanick

    • kosack

    • maxnoe: Needs update with main to fix docs build

    • maxnoe

    • mexanick

  • Chunk interpolation to select calibration data #2634 [ctoennis] calibration new functionality

    I will need a method to select calibration data for the strar tracker. I made some slides to decribe how it is...

    • maxnoe: Why use self._interpolators, why keep that around at all? Why not just call...

      • maxnoe: That's because you didn't move _check_interpolators to the LinearInterpolator but kept it in...

    • maxnoe: Why are we still storing a lambda / partial here in _interpolators? Why not just call...

    • kosack

    • mexanick

    • kosack

  • Fix SubarrayDescription.info for non-unique telescope description strings #2673 [maxnoe]

    Fixes #2672

    • morcuended

  • Add tutorial for mono dl1b to dl2 and update docs #2691 [LukasBeiske]

    This adds a tutorial for using the tools to process dl1b files to dl2 for monoscopic analysis (based on...

    • Tobychev: I think adding an entire tutorial is worth mentioning in the changelog.

    • maxnoe: ctapipe output files are ...

    • maxnoe: Are written, not should be

    • maxnoe: remove

  • Make PSF work with nd-input #2689 [maxnoe]

    Trying to make #2643 work with ND input. Using this script to plot: import astropy.units as u import numpy as...

    • maxnoe: I checked, the result is the same in #2643 when using loops to evaluate single points, so the...

    • maxnoe: @mexanick I pushed some changes to notation and fixed the order of paramters to polyval, with...

    • mexanick: @maxnoe I added workaround for edge cases

    • mexanick

    • mexanick: Looks good to me. @maxnoe can you take a look too, and merge if you're ok with it? I can't...

    • maxnoe: Still looks a bit weird to me (probably due to using polar coordinates with respect to the...

    • maxnoe: Let's merge here and continue in the main pr

  • PSF model #2643 [ctoennis] enhancement calibration new functionality

    I am adding PSF models to ctapipe.image.psf_model. I made a parent class called PSFModel and a PSF model based on...

    • maxnoe: I find calling this azimuth confusing. This is not the azimuth (of the AltAz coordinate system),...

    • maxnoe: Call this ComaPSFModel?

    • maxnoe: Need an empty line here after the description.

    • maxnoe: The two new classes are currently not documented as we don't go down to optics. Best for now...

    • maxnoe: I wanted to make a plot of the psf, but this is giving an error: import astropy.units as...

    • maxnoe: Calling the pdf method should not assign parameters to self

    • maxnoe: needs a [::-1] on the parameters as polyval goes from highest power to lowest power (Horner schema)

    • mexanick: Looks ok for the moment. I've posted one more suggestion of change, but this can be addressed in...

  • Irf maker and cut optimiser #2473 [Tobychev]

    As we are planning to produce IRFs on events that were not used to select the GH cut, it makes sense to split the...

    • kosack: I did a more detailed by-eye code review and have a few suggested changes. I will now do some...

      • kosack: general comment for here and other places: since we have options point_like and...

        • LukasBeiske: See cta-observatory/pyirf#297

    • LukasBeiske: The default values of many config options should probably be changed, but this can also be done...

    • maxnoe: I am really not sure if it is worth changing the terminology here... we will constantly tell...

    • maxnoe: call this event_loaders? I find particles a surprising name for a list of IO objects. Maybe make...

    • maxnoe: Why are we calling this now "precuts" when we chose the term "QualityQuery" precisely to avoid...

      • LukasBeiske: Good point, fixed it.

    • maxnoe: General comment concerning the code base is to not use these unnecessary abbreviations

      • LukasBeiske: I removed the worst offenders I noticed in here, for now

    • maxnoe: It seems kind of an anti-pattern to define an abstract API, but then to do things specifically...

    • maxnoe: Same comment here. Could be implemented via a requires_background property or similar.

      • LukasBeiske: I combined both these properties into one

    • maxnoe: What's the reason this is here and we are not just...

      • maxnoe: ah, I see. This is a slightly different version that uses "roughly" n_bins_per_decade and uses...

      • maxnoe: This could be a bit clearer in the docstring

    • maxnoe: PSF3DMaker

    • maxnoe: PSFMaker

    • kosack

    • maxnoe: I'd invert the option. use_reco_energy with default false. The default should be the "good" option.

    • maxnoe: You could add "if you want to get exactly n_bins_per_decade use pyirf.binning.create_bins_per_decade

    • maxnoe: It's not obvious from the code, but does this class use the create_bins_per_decade function...

    • maxnoe: point-like PSF does not make sense. Even if you include it in the output, which I still don't...

    • maxnoe

    • LukasBeiske

created at 2025-02-03 06:28 by dinghy 1.3.3.