ctapipe Bi-Weekly Digest — Activity since 2026-02-16

» cta-observatory/ctapipe | cta-observatory/ctapipe

• cta-observatory/ctapipe repo issues [back to top]

  • Calculate true_disp when running ctapipe-process #2950 [STSpencer] enhancement good first issue

    Please describe the use case that requires this feature. Currently (as far as I can tell), ctapipe-process does not...

    • maxnoe: If you just want to have a quick look at performance figures, the true disp is stored as part of...

  • HillasIntersection with weighting = "hess" does not work #2805 [calispac] bug

    Describe the bug The weighting method 'hess' of the HillasIntersection reconstructor is not implemented although it...

    • maxnoe: The method has been removed in #2880

  • Add "column" mode to EventPreprocessor: keep but mark events that don't pass qualityquery #2954 [kosack] enhancement

    Please describe the use case that requires this feature. Currently the EventPreprocessor, #2928 (and the older...

  • Cuts and X_max to EventPreprocessor #2953 [kosack] enhancement

    Please describe the use case that requires this feature. Once #2928 is merged, the following features were requested...

  • R1/DL0 telescope event type is also stored in trigger. #2952 [maxnoe] bug

    Describe the bug We store the R1/DL0 telescope event type in three containers, R1, DL0 and TelescopeTrigger. To...

    • kosack: Having it both in R1 and DL0 is fine, since those are mean to have similar info. So I guess...

    • maxnoe: This issue is more about having it also at the trigger container. The field in R1 and DL0 is...

    • maxnoe: We should actually replace the event_type in the trigger container with the trigger type from...

• cta-observatory/ctapipe repo pull_requests [back to top]

  • EarthLocation of the telescopes in subarray #2947 [mexanick]

    add lazy property with telescope coordinates as EarthLocation

    • TjarkMiener

    • mexanick: @maxnoe does this need anything else, or could be merged?

    • maxnoe: Review requested from @kosack

    • kosack

  • Improve developer setup instructions in Getting Started guide #2948 [yaochengchen]

    Clean up the Getting Started developer guide by fixing typos, correcting incorrect Git commands, and aligning...

    • kosack: Looks good otherwise! Thanks

      • kosack: later the document refers to the cta-dev environment (which is the name inside environment.yml),...

        • yaochengchen: @kosack Thanks for pointing this out, sorry about that, I have dropped "-n ctapipe=dev" as you suggested.

    • kosack

    • maxnoe

    • maxnoe: Hi, I am a member of the CTA Consortium and would like to contribute more regularly to...

    • yaochengchen: Hi, I am a member of the CTA Consortium and would like to contribute more regularly to...

  • Test with numba 0.64rc1 #2940 [maxnoe]

  • Extend MonitoringSource interface #2933 [mexanick] new functionality module:IO

    Prepare the interface part to add the DL0/Monitoring source plugin (will come in a separate repository). Therefore,...

    • TjarkMiener: @mexanick Could we switch the base to polish_psfmodel? Then, I'd could use this branch for...

    • mexanick: @mexanick Could we switch the base to polish_psfmodel? Then, I'd could use this branch for...

  • Fix trigger check in HDF5EventSource.is_compatible #2949 [yaochengchen]

    Fix trigger compatibility check has_trigger in HDF5EventSource.is_compatible() incorrectly...

    • maxnoe

    • kosack

  • Implement service data loading #2942 [mexanick]

    Add from_service_data() classmethod to construct SubarrayDescription from service data files using subarray...

    • kosack: any reason you use shutil instead of ...

      • mexanick: Path.copy() was only added in python 3.14, and I believe we should support 3.12 and 3.13

    • mexanick: @maxnoe @kosack ready for review

    • maxnoe: Let's not say "CTAO data model format" until there actually is one. At the moment, this is...

    • maxnoe: Can we add an instrument.meta.json or something similar at the root level here that contains at...

    • maxnoe: Suggested change -...

    • maxnoe: I'd not write "symlinks" here as if that would be prescriptive. Maybe: "Instrument description...

    • maxnoe: Why is this a table with one row? That seems weird in ecsv. We plan to use this for mirror...

      • mexanick: this looks weird because it is current optics.ecsv table (with one row per telescope) split into...

      • maxnoe: But you don't need to modify the optics description code, right? There is no...

    • maxnoe: How is not finding a telescope description for a given subarray only a warning? This needs to be...

    • maxnoe: You can use the monkeypatch fixture for this using monkeypatch.setenv, it will restore automatically.

      • maxnoe: https://docs.pytest.org/en/stable/reference/reference.html#pytest.MonkeyPatch.setenv

      • mexanick: thanks, done!

    • maxnoe: Final comment on general aspects: ctapipe-dump-instrument should support this format as output...

    • mexanick: Final comment on general aspects: ctapipe-dump-instrument should support this format as output...

    • maxnoe: Great, thanks! I'll use that to have a look at the resulting structure for our simulations and...

  • Feature: EventPreprocessor #2928 [kosack]

    Introduces an EventPreprocessor class that can generically transform an event table by applying the following...

    • Voutsi: I think there is a typo here: true_fov_lon shouldn't be reco_fov_lon?

      • kosack: Thanks! not sure how I missed that. I even made plots of the results. But I think that was...

    • mexanick

      • mexanick: there's no dl2_simulation feature set, shall it be added?

        • kosack: I just forgot to rename it in the changelog - it's the one that is implemented so far, for use...

      • mexanick: Shall we perhaps use a registry to allow extension of the feature sets? e.g. class...

        • kosack: Sounds reasonable! That is nice in that it separates these pre-configured options from the core...

        • kosack: implemented. It's indeed much cleaner.

    • maxnoe

    • mexanick: LGTM!

    • Voutsi

    • mdebony: Seems very usefull for DL3 production, I've added a small suggestion in the comments.

      • mdebony: Would be nice if they are possibility to add input kwargs of to function and transmit it to the...

        • kosack: If that's ok, and you think the general structure is fine please accept the review here.

        • kosack: Thanks. I think then I'll merge what is here, and add this feature (and the gamma/hadron cuts...

  • Minimal initial commit of FreePACT code #2920 [ParsonsRD]

    This is a commit of a simple implementation of the FreePACT code. Updates to the ImPACT code are included from #2705

  • Fix a typo in README.md #2955 [yaochengchen]

  • Fix typos in hillas_reconstructor.py #2957 [yaochengchen] no-changelog-needed documentation-only

    Fix typos in hillas_reconstructor.py

    • maxnoe

  • Typo hillas #2956 [yaochengchen] no-changelog-needed documentation-only

    Fix typos in READ.rst and ctapipe.image.hillas.

    • maxnoe: For these kinds of changes, you do not need to provide a changelog. The changelog is for...

      • yaochengchen: Ok, thank you, I just add the changelog to let it pass the CI test.

    • maxnoe: Actually both variants are not entirely correct. To vary, you need more than one, but each...

    • maxnoe: Maybe that's jargon, but we use "one proceeding" to mean a single paper that appeared as part of...

      • maxnoe: Suggested change At this point, our...

    • kosack

    • maxnoe

  • feat: Implement true_disp calculation in ctapipe-process + test #2951 [koopatroopa787]

    Description This PR implements the calculation and storage of true_disp parameters (norm and sign) in...

    • yaochengchen: hi @koopatroopa787 , nice timing 🙂 I was actually working on something similar, but you got...

    • maxnoe: Please remove this unrelated change from this pull request.

      • koopatroopa787: Hii, On Windows, I found that traitlets (or the ctapipe wrapper) struggles to validate absolute...

      • maxnoe: We at the moment explicitly do not support and do not test on windows.

    • maxnoe: disp is not an image parameter and does not belong in this group.

    • maxnoe: Please do not put inline computations inside of the process tool. The CLI is a high-level...

    • maxnoe: We store the predicted disp as a single column, not in separate norm and sign columns. The true...

    • maxnoe: This is not really an image parameter, so should not be part of this data structure. It rather...

      • maxnoe: It can also directly use the DispContainer.

    • koopatroopa787: Hey @yaochengchen and @maxnoe , thanks for the help with this! I'm still getting the hang of...

    • maxnoe: It's good to add this utility, but it should then also be used in the training. Note that we...

    • maxnoe: @koopatroopa787 I am seeing files here that simply do not belong and I see you re-introduced a...

    • koopatroopa787: @koopatroopa787 I am seeing files here that simply do not belong and I see you re-introduced a...

  • Polar PSFModel #2945 [TjarkMiener]

    • kosack: I don't see the attributes asymmetry_params, radial_scale_params or phi_scale_params in the...

      • TjarkMiener: Done in 90eda9c

    • kosack: I think it would be good to give defaults for all the parameters, since running this now without...

    • mexanick: @kosack we only know defaults for LST, but not for other telescopes. With the transition to...

    • kosack: @kosack we only know defaults for LST, but not for other telescopes. With the transition to...

    • maxnoe: Maybe a better way to say it: in all ctapipe components used now, config parameters are always...

    • kosack: In this particular case here, I'm not quite sure what to do. I think providing defaults might be...

    • mexanick: In this particular case here, I'm not quite sure what to do. I think providing defaults might be...

    • kosack: It is in the "instrument" part because it is indeed a characteristic of an instrument, however...

    • maxnoe: You could mimic that with a psf_model StringTelescopeParameter in your parent class, We already...

    • mexanick

    • kosack: Looks ok now, thanks. one question: I was trying to use it to visualize a distorted PSF, but I...

    • mexanick: @TjarkMiener please check/update default parameters after switching to lon/lat, we should get...

    • kosack: If it helps, this is what I plotted above: def plot_psf(psf: PSFModel, lat0=0 * u.deg, lon0=0 *...

    • mexanick

    • TjarkMiener: @kosack @mexanick I pushed a fix for the observed issues. I'm now obtaining reasonable PSFs I'd...

    • maxnoe: Shouldn't this be "offset" and not "center"? It's the constant term in the polynomial, right?

    • maxnoe: Why do we now manually compute a polynomial, when before we were using polyval, which should be...

    • mexanick: @maxnoe I believe the labels and plots are mixed, (just swap HERE <->MAIN or the pairs of plots)...

    • maxnoe: I believe the labels and plots are mixed, Yes, fixed now

    • maxnoe: There still seems to be something off here. I get very different results here than on main for...

    • maxnoe: Why remove the _cartesian_to_polar helper and put the same code inline?

    • maxnoe: This is not needed, the transformation CameraFrame ↔ TelescopeFrame does not require pointing...

    • maxnoe: This should be done once in __init__ and only if the given subarray does not already contain...

    • TjarkMiener: Thanks @maxnoe! I implemented the code suggestions. I'd need to have a closer look on what is...

    • maxnoe: I had a mistake when scaling the radial parameters for the plate scale, with the correct...

    • mexanick: @maxnoe the problem with your plots "here" was due to the fact that for the computation, all the...

    • mexanick: but after your correction to rads, did you update correctly the inputs of the right...

    • maxnoe: the problem with your plots "here" was due to the fact that for the computation, all the values...

    • mexanick: @maxnoe the "working example" is literally your code with one parameter renamed: import...

    • maxnoe: I had lst_plate_scale and lst_plate_scale_rad and I think was using them correctly throughout...

    • maxnoe: Never mind, all fine now. (actually both with the rad and the degrees version). I don't have a...

    • maxnoe: Actually no, we are not using any trig functions on the values.

    • mexanick: no, we are running arcsin on a ratio

    • maxnoe: Note however that the plate scaling in the code you posted above is still wrong. The correct...

    • maxnoe

  • Introduce new `needs_atmosphere_profile` property to reconstructors #2958 [Hckjs] fix maintenance

    Adding also small test

    • maxnoe: While fixing the typo fixes the immediate issue, I'd prefer to fix it properly introducing a new...

    • maxnoe: I'd make this part of the interface, and force implementers to explicitly do it (you can still...

    • maxnoe

    • maxnoe: Two backticks are the correct syntax here. in rst, one tick is a reference, two ticks is code

    • maxnoe

created at 2026-03-02 07:05 by dinghy 1.4.1.