ctapipe Bi-Weekly Digest — Activity since 2026-05-17

» cta-observatory/ctapipe | cta-observatory/ctapipe

• cta-observatory/ctapipe repo issues [back to top]

  • Subarray pointing at DL2+ #3005 [kosack] enhancement

    Please describe the use case that requires this feature. For DL3 output files, we want to have a subarray pointing...

    • maxnoe: Note that at the moment, while GADF allows a pointing table, Gammapy / SAT only support fixed...

    • mexanick: @kosack what is the the definition of the Subarray Pointing? Is it a target, or actual pointing?...

    • maxnoe: What is relevant to DL3 is that the subarray pointing is used to convert between FoV coordinates...

    • mexanick: so this should be the target coordinates then, and not the measured one? Of, if this should be...

    • maxnoe: I think we need to make a quality check on the agreement but then can use the observation block...

  • Calculate true_disp when running ctapipe-process #2950 [STSpencer] enhancement good first issue

    Please describe the use case that requires this feature. Currently (as far as I can tell), ctapipe-process does not...

    • maxnoe: I think computing true_disp in ctapipe-process is not really the best approach. I'd rather make...

• cta-observatory/ctapipe repo pull_requests [back to top]

  • DL3 Event List with EventPreprocessor #3004 [kosack]

    This adds a FeatureSet to the EventPreprocessor for transforming DL2 to DL3 observed events. This is a...

  • Test with astropy 8.0 beta #3006 [maxnoe]

  • Add full cut optimization as introduced in pyirf 0.13 #2789 [LukasBeiske]

    This changes the PointSourceSensitivityOptimizer to use the full cut optimization introduced in pyirf 0.13. The...

    • Hckjs

      • Hckjs: Suggested change theta_min_angle:...

      • Hckjs: Suggested change theta_min_angle:...

  • Pass project version to sonar #2831 [maxnoe] no-changelog-needed

    Fixes the "Version: not provided" in sonarqube

    • mexanick

  • Make HTML reprs for Components recursive #2926 [kosack]

    Minor cosmetic change that I found useful when debugging complex Components that contain other components: recurse...

    • mexanick

  • Add additional nitpick ignores for traitlets #3007 [maxnoe] no-changelog-needed

    • mexanick

    • maxnoe: Merging without a second review as this is a trivial change that fixes the CI.

  • refactor to reduce cognitive complexity #3009 [mexanick]

    • TjarkMiener: Thanks for taking the initiative to solve the SonarQube issue. Minor comment which can be...

      • TjarkMiener: I'd slightly prefer to set to None and then check for not None. But no strong opinion about it.

        • mexanick: In our scenario empty string is a valid part of scenario (do not log in this case), therefore I...

  • Add wrappper to reconstruct Hist object from table row #3010 [TjarkMiener]

    Added thin wrapper for reconstruct Hist object from table rows produced by the HistogramAggregator. I found it super...

    • mexanick

    • TjarkMiener: Can be reviewed or reverted if unnecessary in #2996

  • reorganized stats/chunk containers #2999 [TjarkMiener] maintenance

    We noticed in #2996 that containers dealing with chunks and stats needed some maintenance and docstring polishing.

    • TjarkMiener: I was thinking of replacing this duplication by class ChunkStatisticsContainer(ChunkContainer): ...

      • TjarkMiener: @maxnoe Coming back to this now; sorry for the delay! I’d slightly prefer to keep the changes as...

    • mexanick

    • TjarkMiener: After the docs fix #3007 has been merged the CI is not running here and in #2996. Can you please...

    • maxnoe

    • mexanick

    • kosack: Looks good, just need a changelog entry

  • Allow overriding obs_id by adding offset to run_number in SimTelEventSource #3008 [maxnoe]

    This should make it easier to process the LSTProd2 simulations, where run numbers are only unique within a...

    • STSpencer

    • mdebony

  • Add a StereoDispCombiner #2731 [Hckjs] enhancement algorithm module:reco

    This is basically the StereoCombiner already implemented here in magic-cta-pipe. It combines the mono DISP...

    • maxnoe: This is not needed, we include traitlet help strings automatically.

    • maxnoe: This could be a Quantity traitlet

    • maxnoe: This shouldn't be configurable, just a class variable: property = ReconstructionProperty.GEOMETRY

    • maxnoe: If I read this correctly, we here silently ignore the case where a user asked the disp...

    • maxnoe: This check could be done before evaluating the quality query for performance

    • maxnoe: np.nan is an immutable float, it will always be copied, so no need to add COPY_IF_NEEDED.

      • maxnoe: you can see this also when passing copy=False, it will always raise an error that the copy could...

      • maxnoe: I'd also move this line to an else below, so that it is only called when needed.

    • maxnoe: This could be a separate issue, but I'm not sure that the code here would be correct for...

    • maxnoe: for performance, it would probably be better to create arrays of length n_telescopes before the...

      • maxnoe: Similarly how it is done here for the HillasReconstructor: ...

    • maxnoe: I think these parts deserve some comments. It is not obvious to me what e.g. lexsort is achieving here

  • Add DL3 writer #2979 [mdebony]

    Add a DL3 writer for the GADF format to catapipe. This PR is sub element of #2727 to simplify the review.

    • kosack: I'm still working through this, so this is not yet a complete review, but here are a few initial comments

      • kosack: I'd suggest just using quantities here: Suggested change ...

        • kosack: Or better yet, why not just use astropy's implementation

        • mdebony: Done

      • kosack: If you like, I can open a PR to this branch to convert this to use the new EventPreprocessor,...

        • kosack: See #3004 where I started to see what changes I need to EventPreprocessor to support the DL2 to...

        • mdebony: Please feel free to do it.

    • maxnoe: My main comment here is that I think that the DL3 writer should not store state of the...

      • mdebony: I've added the a data class as suggested and it should address your comments. Let me know.

    • maxnoe: It looks more like this is a data class storing all information that should go into a DL3 file,...

      • mdebony: Done

  • First step of implementing CEP-002: Change container structure #2204 [maxnoe]

    Closes #1165 Closes #2170 Closes #2374 Closes #2952

  • added HistogramsAggregator #2996 [TjarkMiener]

    closes #577

    • mexanick: Why is this a public method? Is it used outside of this class?

      • TjarkMiener: This is currently a public method for consistency with the analogue in StatisticsAggregator,...

      • mexanick: Base class doesn't define such interface, therefore I prefer to keep it private. Also I'm not...

      • TjarkMiener: Sounds good to me @mexanick! It is implemented in 6a40c6a. I thought it might be useful for the...

    • TjarkMiener: Thanks for the useful comments @kosack. I took them into consideration, so the current version...

    • TjarkMiener: SonarQube is currently failing due to complexity issues in pre-existing code, although this...

    • mexanick: I would not mask all invalid values like this. They are outliers of a different origin and...

      • TjarkMiener: Yes good catch, it is kind of an artifact from where we did not had the under/overflow...

    • mexanick

  • Adding a single documentation page with image parameters (features) #3011 [vuillaut]

    This PR introduces a new entry in the user doc "analysis steps" (could be completed later) including a page with all...

created at 2026-05-31 08:52 by dinghy 1.4.1.