ctapipe Bi-Weekly Digest — Activity since 2026-04-10

» cta-observatory/ctapipe | cta-observatory/ctapipe

• cta-observatory/ctapipe repo issues [back to top]

  • Plate-Scale Calibrations #2985 [burmist-git]

    From DPPS Level B Requirements Specification_stamped.pdf: 9.8.28 CTAO-B_DPPS-435 - Plate-Scale Calibrations. The...

    • maxnoe: @burmist-git please see message in slack before opening more issues

  • Correction for non-active pixels for muon analysis #2987 [burmist-git]

    From DPPS_LevelB_Requirements_Batch3_Calibration.xlsx: B-DPPS-37XX Correction for non-active pixels for muon...

  • Removal of non-active pixels from the signal predictor #2986 [burmist-git]

    From DPPS_LevelB_Requirements_Batch3_Calibration.xlsx: B-DPPS-37XX Removal of non-active pixels from the signal...

  • Calibration of the Muon Analysis Using Simulations #2983 [burmist-git]

    From DPPS Level B Requirements Specification_stamped.pdf: 9.8.23 CTAO-B_DPPS-439 - Calibration of the Muon Analysis...

  • Non-spherical reflectors for muon analysis. #2988 [burmist-git]

    Polygonal description of the chord, including the possibility of having a mirror-by-mirror description. #2969

  • Finite camera focus for muon analysis #2989 [burmist-git]

    Correct for the bias on the reconstructed Cherenkov angle due to the effect of finite camera focuses for the muon...

  • Geomagnetic field effects for muon analysis #2990 [burmist-git]

    Include effect of bending of the muon trajectory due to geomagnetic field Eqs. 49-51 of [RD]...

    • maxnoe: I think at the moment, we only have the B-Field in the simulations. @kosack I think this should...

  • Optimize the computation by using photon energy instead of wavelength. #2992 [burmist-git]

    Optimize the computation by using photon energy instead of wavelength. This is related to the fact that Cherenkov...

    • maxnoe: This is not purely an optimization, it will change the result from being a percentage efficiency...

  • Secondary mirror / camera shadow awareness for inclined muon analysis #2991 [burmist-git]

    Impact distance reconstruction of the muon analysis depends from shadows from the camera and the central hole in the...

    • maxnoe: Related to #1252 and #1259

  • Reference metadata being checked before its is written in CrossValidator #2973 [kosack] bug

    Describe the bug We get a warning like: ctapipe/core/provenance.py:280: MissingReferenceMetadata: Could not read...

  • Expose CORSIKA photons in the SimulatedEventContainer #2698 [vmharvey] enhancement

    Please describe the use case that requires this feature. I'm doing some studies that use the CORSIKA photon bunches...

    • kosack: Sounds fine to me - I had thought you wanted to write them out to the HDF5 files, which is a bit...

  • Add proper type annotations for containers / fields #2993 [maxnoe] enhancement

    Please describe the use case that requires this feature. Currently, type checkers complain about the containers /...

  • Waveform Time of Maximum Calculation #2982 [Cormed-Mack] bug

    Hi, I'm Cara Dignam I work at IRAP on NectarCam. The calculation of the peak time in /src/ctapipe/image/extractor.py...

  • Master issue on muons after the CERN meeting #2981 [burmist-git]

    The points are presented in chronological order, as they were discussed. If a point is marked with the (closed)...

  • Pixel-wise aggregation of histograms #577 [calispac] enhancement

    Hi all, I am wondering if there is any plan to have a class/function to create an histogram along a given axis (e.g....

    • TjarkMiener: We are working towards the support of SPE fitting within calibpipe, therefore we need to...

    • maxnoe: @TjarkMiener please also see code in lstcam-calib that is very similar (computing running means...

    • calispac: @TjarkMiener FYI this the repo we wrote to solve this issue :...

  • Add test for DataWriter with observed data #2998 [maxnoe] enhancement

    Please describe the use case that requires this feature. During #2204, I noticed that it was passing tests, but...

• cta-observatory/ctapipe repo pull_requests [back to top]

  • Add check in lts_linear_regression to prevent seg faults #2878 [Hckjs] bug

    Passing less than 2 valid points into lts_linear_regression leads to segmentation faults. See #2877 #2876 #2875

  • Pass CameraMonitoringContainer to ImageCleaner in ImageProcessor #2875 [Hckjs] bug

    fixes #2874

  • Changes for use in the event Processor of the NSB addition to waveforms #2980 [moralejo]

    This allows to add NSB in waveforms before proceeding with the pulse integration and the rest of the processing.

    • kosack

  • add polygon_chord #2969 [burmist-git]

    Polygonal description of the chord. 096_arbitrary_shaped_mirror_and_polygon_chord.pdf Uploading...

    • mexanick

      • mexanick: why not using try: ... except ZeroDivisionError: # determinant is zero, the cord goes on the...

        • kosack: Just remember that catching an exception is quite a bit slower than adding an epsilon, so if you...

        • maxnoe: And doesn't vectorize

  • Fix incorrect warning in CrossValidator #2974 [kosack]

    Add output file to provenance only after it is closed. Fixes #2973

    • maxnoe

    • LukasBeiske

  • Store original simtel event in ArrayEventContainer #2976 [vmharvey]

    Closes #2698. Note that the telescope numbering scheme inside the simtel event is different to the final ArrayEvent.

    • kosack

    • maxnoe

  • Implement square pixels on a hexgrid #2932 [maxnoe]

    Store new field in geometry files tests import numpy as np import matplotlib.pyplot as plt from ctapipe.instrument...

    • maxnoe: Merging, since approved by karl and @AtreyeeS

  • Build on windows #2156 [kosack] no-changelog-needed

    Just a quick test to see what breaks if ctapipe is installed in windows... If it's not too much, I will try to fix...

  • Add full cut optimization as introduced in pyirf 0.13 #2789 [LukasBeiske]

    This changes the PointSourceSensitivityOptimizer to use the full cut optimization introduced in pyirf 0.13. The...

  • Make HTML reprs for Components recursive #2926 [kosack]

    Minor cosmetic change that I found useful when debugging complex Components that contain other components: recurse...

  • Polar PSFModel #2945 [TjarkMiener]

    • maxnoe: This seems a very complicated way to write: Suggested change ...

    • maxnoe: There is a factor of 0.5 missing here I think since the pixel_width is the diameter (circle) /...

    • maxnoe: this should also check against pixel_radius, right? To be consistent?

      • mexanick: in general, this is different approximation condition, but for consistency I made it...

    • maxnoe

    • kosack

  • Add proper typing support for Container fields #2994 [maxnoe]

    With e.g. pyright installed in an IDE: Before: Now: And e.g. in CameraCalibrator: Before: Now: It cannot deduce...

    • kosack

    • mexanick: thanks, great QoL improvement!

  • Add one more type annotation to Field overloads #2995 [maxnoe] no-changelog-needed

    While going over the container definitions in #2204, I noticed one missing case where my IDE was complaining about...

    • mexanick

    • mexanick

  • Implement service data loading #2942 [mexanick]

    Add from_service_data() classmethod to construct SubarrayDescription from service data files using subarray...

    • maxnoe: Why do we start at 2.0?

      • mexanick: Inherited from this: CURRENT_TAB_VERSION = "2.0" should I decouple?

      • maxnoe: That's different versions, right? One is the table format of the layout table, one is the...

      • mexanick: Yes, they are different and could change independently, I just didn't feel comfortable...

    • maxnoe: This assumes that CTAPIPE_SVC_PATH directly has the instrument data structure. Do we really want...

      • kosack: Yes, that would be nicer - I didn't actually try loading from the service path. Otherwise we...

    • maxnoe: Here you have the instrument level. So I would assume to have this as written above

    • kosack

    • maxnoe: Looks mostly good (already wanted to approve). Only there is a missing import now in the conftest

    • mexanick: @maxnoe @kosack I've addressed the comments and rebased on the current main, should be ready for...

    • maxnoe

  • EventViewer as part of ctapipe-process tool #2556 [maxnoe]

    This adds a QT based GUI EventViewer that can be started and used to browse through event data using ctapipe-process...

  • Fix Map() repr to be more sane #2997 [kosack]

    The old repr was basically unreadable, as it printed the reprs of all sub-containers. This just changes the repr to...

    • maxnoe: Map(ctapipe.containers.DL1CameraContainer: [np.int16(5), np.int16(11)]) I find it a bit weird...

  • Add a StereoDispCombiner #2731 [Hckjs] enhancement algorithm module:reco

    This is basically the StereoCombiner already implemented here in magic-cta-pipe. It combines the mono DISP...

    • maxnoe: Why is two a special case here? Don't we need to check min_ang_diff for each pair and check if...

    • Hckjs: Why is two a special case here? Don't we need to check min_ang_diff for each pair and check if...

  • First step of implementing CEP-002: Change container structure #2204 [maxnoe]

    Closes #1165 Closes #2170 Closes #2374 Closes #2952

    • maxnoe: Move into dl0?

      • Tobychev: There is also pointing information in the tel field below, although it is per telescope rather...

      • Tobychev: Not sure, is it very helpful? Putting pointing in dl0 means you can't make geometry...

    • maxnoe: @kosack @mexanick This is now rebased on current main (not fun!) and locally tests are passing...

    • maxnoe: There is one change in the file format here as well, not just to the in-memory containers: to...

    • maxnoe: Add migration guide details here.

    • mexanick: I think the DL1 trigger table paths should be removed as that tables do not exist anymore

      • mexanick: Suggested change ...

      • mexanick: Suggested change

    • maxnoe: I think the DL1 trigger table paths should be removed as that tables do not exist anymore These...

    • kosack: EDIT: never mind, I was looking at RandomForestRegressor_energy and not...

    • kosack: Looks very good! i don't see any major issues, and anything else can be cleaned up in future...

    • kosack: Note that I opened #2997 to fix a long-standing bug, which made exploring the new structure a...

    • maxnoe: FYI: here is a PR in the ctapipe_io_zfits plugin working with this branch:...

  • added HistogramsAggregator #2996 [TjarkMiener]

    closes #577

    • maxnoe: Is this the histogrammed data? That shouldn't be called bins, as e.g. np.histogram use the bins...

      • mexanick: what's a difference between these bins and counts above besides the field name?

      • mexanick: Also since this is specific to the camera, I would avoid calling it with generic name such as...

      • TjarkMiener: Those are the bin edges. I'm proposing to rename bins -> edges and HistogramContainer ->...

      • maxnoe: then the "shape" docstring is wrong. The edges have length n_bins + 1.

      • kosack: Maybe follow what we do in SimulatedShowerDistribution, which stores a histogram.

    • maxnoe: There should be configuration options here for the histogram, i.e. number of bins or directly...

      • maxnoe: I don't understand the latest changes here. You had configuration options here, but now they are...

      • TjarkMiener: @maxnoe sorry for the confusion! Indeed, the last changes mixing up different things. The...

      • maxnoe: For the usecase mentioned below (the MAGIC/EventDisplay cleaning) the histograms are the...

      • maxnoe: Also for the SPE fitting, I think we should be able to store the distributions to which the SPE...

    • maxnoe: Note that this kind of histogram monitoring is for example also needed for the cleaning...

    • maxnoe: I think for these histograms to be useful, we need to ensure that each chunk is using the same...

    • TjarkMiener: I think for these histograms to be useful, we need to ensure that each chunk is using the same...

    • maxnoe: I'd suggest to use min and max instead of a range list, as it is always two values, not an...

    • maxnoe: These seem very arbitrary. I would not provide such defaults. Since we at the moment anyway load...

    • maxnoe: Since the edges are forced to be the same for all rows, I would not add them to the table. Add...

    • maxnoe: Does this actually provide additional information? I would assume it is actually just returning...

    • TjarkMiener: Suggested change - v7.6.0: - Add new...

    • maxnoe: please don't put the type in the name, e.g. just axis_definition or binning.

    • maxnoe: Could we not have the "kwargs" level? E.g. use something like this: kwargs =...

created at 2026-04-24 08:11 by dinghy 1.4.1.